Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix logging crash when timestamp=True for the file log handler #3215

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[bugfix] Fix logging crash when timestamp=True for the file log handler #3215

merged 1 commit into from
Jun 18, 2024

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Jun 14, 2024

Closes #3128.

@vkarak vkarak added this to the ReFrame 4.7 milestone Jun 14, 2024
@vkarak vkarak requested review from victorusu and teojgo June 14, 2024 21:14
@vkarak vkarak self-assigned this Jun 14, 2024
@vkarak vkarak linked an issue Jun 17, 2024 that may be closed by this pull request
Can't set logging.handlers.file.timestamp to true #3128
Closed
victorusu
victorusu approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 16f478e into reframe-hpc:master Jun 18, 2024
23 checks passed
@vkarak vkarak deleted the bugfix/file-handler-timestamp-boolean branch June 18, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teojgo teojgo teojgo approved these changes

@victorusu victorusu victorusu approved these changes

Assignees

@vkarak vkarak

Labels
bugfix prio: normal
Projects
ReFrame Backlog
Status: Done
Milestone
ReFrame 4.7
Development

Successfully merging this pull request may close these issues.

Can't set logging.handlers.file.timestamp to true
3 participants
@vkarak @victorusu @teojgo