Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Update Job.nodelist description #3155

Merged

Conversation

jack-morrison
Copy link
Contributor

@jack-morrison jack-morrison commented Apr 10, 2024

Fixes #3143.

@vkarak I'm not seeing the recent PBS change you mentioned on #3143 - do you mind pointing me to it? Am I correct in assuming that Slurm is no longer the only backend where this attribute is reliably set?

@jack-morrison jack-morrison added this to the ReFrame 4.6 milestone Apr 10, 2024
@jack-morrison jack-morrison requested a review from vkarak April 10, 2024 20:22
@jack-morrison jack-morrison self-assigned this Apr 10, 2024
@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@vkarak
Copy link
Contributor

vkarak commented Apr 11, 2024

ok to test

@vkarak
Copy link
Contributor

vkarak commented Apr 11, 2024

@vkarak I'm not seeing the recent PBS change you mentioned on #3143 - do you mind pointing me to it? Am I correct in assuming that Slurm is no longer the only backend where this attribute is reliably set?

The docs are from version 3.2 (see 0f1c2a9), but the support for the nodelist in PBS came in 3.3 (see 330c7b4). The full list of the backends that support it is: local, pbs, slurm, squeue, ssh, torque.

@jack-morrison jack-morrison force-pushed the jackm/docs-pbs-nodelist branch from 23b3cb2 to d873504 Compare April 11, 2024 23:08
@vkarak vkarak changed the title [doc] Update Job.nodelist description [doc] Update Job.nodelist description Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.65%. Comparing base (60b2152) to head (bd4dd0e).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3155   +/-   ##
========================================
  Coverage    86.65%   86.65%           
========================================
  Files           61       61           
  Lines        12117    12117           
========================================
  Hits         10500    10500           
  Misses        1617     1617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-morrison jack-morrison merged commit 91147de into reframe-hpc:develop Apr 12, 2024
25 checks passed
@jack-morrison jack-morrison deleted the jackm/docs-pbs-nodelist branch April 15, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Docs erroneously state that job's nodelist retrieval is not supported for the PBS backend
3 participants