Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: UI jumps when open calendar then scroll from the view and click outside #44

Conversation

zzz1ck
Copy link

@zzz1ck zzz1ck commented Oct 21, 2024

Fixes https://github.com/reedsy/vui/issues/1416 issue

Before

dropdown-calendar-outer-click-behaviour-before.mov

After

dropdown-calendar-outer-click-behaviour-after.mov

@zzz1ck zzz1ck self-assigned this Oct 21, 2024
Copy link

@ricardoferrolho ricardoferrolho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add tests for this.

Copy link

@ricardoferrolho ricardoferrolho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zzz1ck zzz1ck merged commit 3cd6c63 into main Oct 22, 2024
1 check passed
@zzz1ck zzz1ck deleted the 1416-the-ui-jumps-when-datepicker-is-open-you-scroll-down-and-click-anywhere branch October 22, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants