chore(rsc): Rename rscFetch to rscFetchRoutes and hardcode the rscId #11407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
force-pushed
the
tobbe-rscfetch-rscfetchroutes
branch
from
6ad442a to
a24705c
Compare
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Sep 2, 2024
…ads-storage * 'main' of github.com:redwoodjs/redwood: (32 commits) chore(uploads): Reorganise, change uploads package to storage (redwoodjs#11411) fix(cli-helpers): Don't add spaces around `=` for env vars (redwoodjs#11414) feat(uploads): Increase default fastify body limit to 100MB (redwoodjs#11412) chore: Rebuild fixture (redwoodjs#11413) chore(rsc): Refactor: Rename RscFetcher -> RscRoutes (redwoodjs#11409) chore(test-project): Update postcss to 8.4.42 (redwoodjs#11408) chore(rsc): Rename rscFetch to rscFetchRoutes and hardcode the rscId (redwoodjs#11407) feat(rsc): Initial support for RSA rerender (redwoodjs#11406) chore(router): Switch to experimental types (redwoodjs#11405) chore(router): Make React a normal dependency (redwoodjs#11404) feat(rsc): Return flight from RSAs (redwoodjs#11403) rscRequestHandler.ts: Make BASE_PATH naming match client.ts (redwoodjs#11401) fix(template): api type declaration merging for scripts (redwoodjs#11367) RSC: Disable client side flight caching for now (redwoodjs#11400) chore(fixtures): Use proper name for AuthLayout component (redwoodjs#11399) feat(storage): Add support for createMany, updateMany and upsert (redwoodjs#11390) feat(codegen): support sdl generation for model with compound id (redwoodjs#8556) chore(ci): Follow up to workflow permissions (redwoodjs#11397) chore(deps): Bump 'loader-utils' within docs (redwoodjs#11396) chore(ci): Pin action dependencies by digest (redwoodjs#11395) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always just fetching the same component (which means we were always using the same
rscId). So I renamed the function to be more explicit in what it does, and then got rid of therscIdargument as it was always just the same string anyway. So now the id is hardcoded inside the function