-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer use of Action or UnknownAction instead of AnyAction #4520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 61515da:
|
✅ Deploy Preview for redux-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
EskiMojo14
changed the title
Encourage use of Action or UnknownAction instead of AnyAction
Prefer use of Action or UnknownAction instead of AnyAction
Apr 16, 2023
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 🐛 Bug fix or new feature
about: Fixing a problem with Redux
PR Type
Does this PR add a new feature, or fix a bug?
Experiments with using Action and UnknownAction to avoid usage of AnyAction.
Why should this PR be included?
AnyAction introduces unwanted and unsafe
any
values into codebases.UnknownAction allows accessing (and passing) arbitrary top level keys, but forces the reducer to check the value before use.
Action only allows access to the type property, until type guarded to allow extra properties. (safest, but most inconvenient)
Checklist
action
is typed asany
#4518also includes changes from #4519 and #4491 to build upon