Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp rollup.config.js #4311

Merged
merged 3 commits into from
Mar 12, 2022
Merged

Revamp rollup.config.js #4311

merged 3 commits into from
Mar 12, 2022

Conversation

xty
Copy link
Contributor

@xty xty commented Mar 11, 2022

This PR introduces the following improvements to the Rollup configuration file:

  1. compress.warnings is not a valid Terser option, as can be seen in Terser's docs and type declarations. Therefore, it has been removed.
  2. To minimize the likelihood of making similar mistakes, Intellisense has been enabled for rollup.config.js, as recommended in Rollup's docs.
  3. Currrently, the makeExternalPredicate function involves a great deal of indirection in preparing the external object. The fact that Rollup can accept an array of RegExps as external has made this a lot more straightforward.

Checklist

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated to match the changes in the PR?
  • Have the tests been updated to match the changes in the PR?
  • Have you run the tests locally to confirm they pass?

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff328f3:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@timdorr
Copy link
Member

timdorr commented Mar 12, 2022

Thanks!

@timdorr timdorr merged commit 535b95e into reduxjs:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants