Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to lodash v4.2.0. #1349

Merged
merged 1 commit into from
Feb 2, 2016
Merged

Update to lodash v4.2.0. #1349

merged 1 commit into from
Feb 2, 2016

Conversation

jdalton
Copy link
Contributor

@jdalton jdalton commented Feb 2, 2016

This closes #1346.

@stoeffel
Copy link

stoeffel commented Feb 2, 2016

How about including lodash.isPlainObject instead of the complete lodash?

gaearon added a commit that referenced this pull request Feb 2, 2016
@gaearon gaearon merged commit e00b709 into reduxjs:master Feb 2, 2016
@gaearon
Copy link
Contributor

gaearon commented Feb 2, 2016

@stoeffel It doesn't really matter because we import just that module.

@stoeffel
Copy link

stoeffel commented Feb 2, 2016

Agreed.
We're not using redux directly, but we use react-dnd.
We depend on react-dnd with a fixed dependency, but react-dnd depends on dnd-core (not fixed) and dnd-core depends on redux (not fixed).
Our webpack was configured to alias lodash to one global lodash, I guess the intention behind that was to reduce client-size. This led to a failing build because we are still using lodash v3, which wouldn't have happened if redux would use lodash.isPlainObject or the dependencies in dnd-core and react-dnd were fixed.
But IMO we need to change that anyway, because other libs will probably update to lodash v4 soon.

@gaearon
Copy link
Contributor

gaearon commented Feb 2, 2016

Yes, that's a big assumption to make.
Wanna send a PR to update Lodash in DnD?

@stoeffel
Copy link

stoeffel commented Feb 2, 2016

Wanna send a PR to update Lodash in DnD?

Will try to find some time to create a PR, but maybe someone will be faster.

@jdalton jdalton deleted the lodash-update branch February 2, 2016 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.2.0 Global not defined with in isPlainObject
3 participants