Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: Add License violations to rpk cluster info #23744

Merged
merged 3 commits into from
Oct 17, 2024
Merged

rpk: Add License violations to rpk cluster info #23744

merged 3 commits into from
Oct 17, 2024

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Oct 11, 2024 •
edited
Loading

This PR adds the output of /v1/features/enterprise to rpk cluster license info. It also changes the warning message and the cache to be invalidated after 1 hour:

Examples

License loaded:

WARNING: your license will expire soon.

LICENSE INFORMATION
===================
License status:              valid
License violation:           false
Enterprise features in use:  [partition_auto_balancing_continuous]
Organization:                Devex
Type:                        enterprise
Expires:                     Oct 11 2024

No License, Violation:

LICENSE INFORMATION
===================
License status:              not_present
License violation:           true
Enterprise features in use:  [partition_auto_balancing_continuous]

No License, No Violation:

LICENSE INFORMATION
===================
License status:          not_present
License violation:       false

Expired License with new warning message

WARNING: The following Enterprise features are being used in your Redpanda cluster: [partition_auto_balancing_continuous]. These features require a license. To get a license, contact us at https://www.redpanda.com/contact. For more information, see https://docs.redpanda.com/current/get-started/licenses/#redpanda-enterprise-edition

LICENSE INFORMATION
===================
License status:              expired
License violation:           true
Enterprise features in use:  [partition_auto_balancing_continuous]
Organization:                Devex
Type:                        enterprise
Expires:                     Oct 11 2024
License expired:             true

JSON format

{"license_status":"valid","organization":"Devex","type":"enterprise","expires":"Oct 17 2024","expires_unix":1729190366,"checksum_sha256":"382c69f94cbdebcab3da32c69f94cbdebcab62152c69f94cbdebcc213ac4c08","license_expired":false,"license_violation":false,"enterprise_features_in_use":["partition_auto_balancing_continuous"]}

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Improvements

  • rpk cluster license info: now includes more information about your license status and possible violations.

@r-vasquez r-vasquez marked this pull request as draft October 11, 2024 00:36
@r-vasquez r-vasquez force-pushed the devex-27-license-info branch from 91550b7 to d7ab334 Compare October 11, 2024 16:05
@redpanda-data redpanda-data deleted a comment from vbotbuildovich Oct 11, 2024
@redpanda-data redpanda-data deleted a comment from vbotbuildovich Oct 11, 2024
@r-vasquez r-vasquez marked this pull request as ready for review October 11, 2024 16:06
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 11, 2024 •
edited
Loading

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56365#01927c95-8a31-4479-acbe-9b3bd489c322:

"rptest.tests.partition_move_interruption_test.PartitionMoveInterruption.test_cancelling_partition_move.replication_factor=1.unclean_abort=True.recovery=no_recovery.compacted=False"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56365#01927c99-a49d-4a56-9ed0-a3ccd67d5777:

"rptest.tests.idempotency_test.IdempotencyWriteCachingTest.test_idempotent_producers_write_caching"

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 11, 2024 •
edited
Loading

Retry command for Build#56365

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/partition_move_interruption_test.py::PartitionMoveInterruption.test_cancelling_partition_move@{"compacted":false,"recovery":"no_recovery","replication_factor":1,"unclean_abort":true}
tests/rptest/tests/cloud_storage_timing_stress_test.py::CloudStorageTimingStressTest.test_cloud_storage@{"cleanup_policy":"delete"}
tests/rptest/tests/idempotency_test.py::IdempotencyWriteCachingTest.test_idempotent_producers_write_caching

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 11, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56365#01927c99-a49d-4a56-9ed0-a3ccd67d5777
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56365#01927c99-a49f-43ef-8391-dae0a1dbb025
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56365#01927c99-a4a2-4b38-8775-fc93edd61154
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56410#01927ee2-ded5-42c5-8841-e4181bea4647
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56410#01927ee6-c570-45e8-9936-14fe37dd90a8
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56410#01927ee6-c572-4ea6-8a81-24aa5a1957c5
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56410#01927ee6-c575-405b-abfc-524cd78b7869
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56410#01927ee6-c573-45d8-9c66-1954f616ca19
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56476#01928c3a-1f9b-4c50-81ed-60cd05946e88
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56476#01928c54-a466-44ce-be22-4c7eaaf4db55
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56476#01928c54-a469-411a-bb4f-93c71418797c
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56476#01928c54-a46c-4144-83cb-416d5db575b7
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56476#01928c54-a46e-487a-934f-6350ca46ec4b
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56691#01929831-e026-42f2-ae0f-b65bfc6f7e12
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56691#01929845-c5bd-48f3-a9f2-39ae7885ff42

@r-vasquez r-vasquez force-pushed the devex-27-license-info branch from d7ab334 to 542feda Compare October 12, 2024 02:49
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 12, 2024 •
edited
Loading

Retry command for Build#56410

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/cloud_storage_timing_stress_test.py::CloudStorageTimingStressTest.test_cloud_storage@{"cleanup_policy":"delete"}
tests/rptest/tests/cloud_storage_timing_stress_test.py::CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves@{"cleanup_policy":"delete"}

@r-vasquez
Copy link
Contributor Author

/ci-repeat 1
tests/rptest/tests/cloud_storage_timing_stress_test.py::CloudStorageTimingStressTest.test_cloud_storage@{"cleanup_policy":"delete"}
tests/rptest/tests/cloud_storage_timing_stress_test.py::CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves@{"cleanup_policy":"delete"}

@vbotbuildovich
Copy link
Collaborator

the below tests from https://buildkite.com/redpanda/redpanda/builds/56476#01928bf9-d41d-4ea2-b99d-898c3e88a6f6 have failed and will be retried

gtest_raft_rpunit

@david-yu
Copy link

This looks good to me. Thank yoiu @r-vasquez

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 14, 2024 •
edited
Loading

Retry command for Build#56476

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/cloud_storage_timing_stress_test.py::CloudStorageTimingStressTest.test_cloud_storage@{"cleanup_policy":"delete"}
tests/rptest/tests/cloud_storage_timing_stress_test.py::CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves@{"cleanup_policy":"delete"}

@r-vasquez r-vasquez force-pushed the devex-27-license-info branch from 542feda to ad0298e Compare October 16, 2024 19:13
@r-vasquez r-vasquez force-pushed the devex-27-license-info branch from ad0298e to 819e546 Compare October 16, 2024 22:17
@r-vasquez
rpk: check for empty profiles in license check.
44dfa80 
This is to avoid a panic in the edge case when the
user has a nameless profile (corrupted file)
@r-vasquez r-vasquez force-pushed the devex-27-license-info branch from 819e546 to 44dfa80 Compare October 17, 2024 00:40
gene-redpanda
gene-redpanda approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r-vasquez r-vasquez merged commit 3f944f5 into redpanda-data:dev Oct 17, 2024
24 checks passed
This was referenced Oct 17, 2024
Merged
Merged
@r-vasquez r-vasquez deleted the devex-27-license-info branch October 22, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deflaimun Deflaimun Deflaimun left review comments

@gene-redpanda gene-redpanda gene-redpanda approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@mattschumpert mattschumpert Awaiting requested review from mattschumpert

@ivpanda ivpanda Awaiting requested review from ivpanda

Assignees
No one assigned
Labels
area/build area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@r-vasquez @vbotbuildovich @david-yu @Deflaimun @gene-redpanda