Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: migrate namespace to resource group #18149

Merged
merged 3 commits into from
May 6, 2024

Conversation

r-vasquez
Copy link
Contributor

This PR updates the Cloud's Namespace field to use Resource Group in the rpk codebase where we use the Public API.

This includes bumping the Cloud's Public API from v1Beta1 to v1Beta2, and bumping the rpk.yaml's version.

The PR also renames rpk cloud namespace to rpk cloud resource-group, but remember that this was a hidden and undocumented command. Namespace still works as an alias.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

r-vasquez added 2 commits May 1, 2024 14:00
This also involves upgrading the control plane API
beta v1 to v2 and dealing with the breaking changes
@r-vasquez r-vasquez force-pushed the migrate-namespace branch from 3c83248 to f387042 Compare May 1, 2024 21:18
@r-vasquez r-vasquez marked this pull request as ready for review May 1, 2024 21:18
@r-vasquez r-vasquez force-pushed the migrate-namespace branch from f387042 to 3b2ba6a Compare May 1, 2024 21:21
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented May 1, 2024

new failures in https://buildkite.com/redpanda/redpanda/builds/48580#018f365b-36cd-46b3-8fe3-cda17f2faf36:

"rptest.tests.read_replica_e2e_test.ReadReplicasUpgradeTest.test_upgrades.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48580#018f365b-36d0-45dd-bf36-a4d1a4178b46:

"rptest.tests.upgrade_test.UpgradeFromPriorFeatureVersionCloudStorageTest.test_rolling_upgrade.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48580#018f3662-1b23-4685-8250-4c4503ec8844:

"rptest.tests.read_replica_e2e_test.ReadReplicasUpgradeTest.test_upgrades.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_cross_shard.num_to_upgrade=2.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_shadow_indexing.num_to_upgrade=2.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48580#018f3662-1b2a-407e-9dcc-84fdb9df871d:

"rptest.tests.upgrade_test.UpgradeFromPriorFeatureVersionCloudStorageTest.test_rolling_upgrade.cloud_storage_type=CloudStorageType.S3"

@r-vasquez r-vasquez force-pushed the migrate-namespace branch from 3b2ba6a to 7258520 Compare May 2, 2024 22:42
@r-vasquez
Copy link
Contributor Author

Force Push:

Adds back the namespace field and adds a migration mechanism for profiles that have the "namespace" value.

@r-vasquez r-vasquez force-pushed the migrate-namespace branch from 7258520 to 15fd472 Compare May 2, 2024 22:44
And bump version accordingly
@r-vasquez r-vasquez force-pushed the migrate-namespace branch from 15fd472 to c36daed Compare May 6, 2024 15:57
@r-vasquez r-vasquez requested a review from twmb May 6, 2024 15:58
@r-vasquez r-vasquez merged commit bca2d58 into redpanda-data:dev May 6, 2024
22 checks passed
@r-vasquez r-vasquez deleted the migrate-namespace branch May 23, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants