Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus.io/scrape etc are podAnnotations, not labels. #135

Merged
merged 3 commits into from
Dec 30, 2021
Merged

prometheus.io/scrape etc are podAnnotations, not labels. #135

merged 3 commits into from
Dec 30, 2021

Conversation

BitProcessor
Copy link
Contributor

Fixes the sample values.

@weeco
Copy link
Contributor

weeco commented Dec 30, 2021

Hey @BitProcessor ,
makes sense to move the suggested values to the more commonly used place - which are pod annotations rather than labels.

I think we don't require a new chart release for that and therefore you can revert the changes on the Chart.yaml file. Thanks!

@weeco weeco merged commit 05a03ed into redpanda-data:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeco weeco weeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BitProcessor @weeco