Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scylla connector #2746

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dkropachev
Copy link

@dkropachev dkropachev commented Jul 29, 2024

It is essentially copy of cassandra connector.
Only two options added:

  1. Consistency level
  2. Host policy config

Since github.com/scylladb/gocql has github/gocql/gocql module name it is necessary to have go.mod in scylla connector directory with replace directive.

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2024

CLA assistant check
All committers have signed the CLA.

It is essentially copy of cassandra connector
Only added consistency level and host policy config
Since github.com/scylladb/gocql has "github/gocql/gocql" in go.mod
 it is necessary to have go.mod in scylla connector directory with
 "replace" directive.
@dkropachev dkropachev force-pushed the feat-add-scylla-connector branch from 2b72fcb to 68e0e64 Compare July 29, 2024 23:42
@mihaitodor
Copy link
Collaborator

Thank you @dkropachev! I haven’t looked at the code in detail yet, but I was wondering if this issue scylladb/gocql#161 will get resolved soon to avoid having to maintain the go.mod replace directives.

@dkropachev
Copy link
Author

Thank you @dkropachev! I haven’t looked at the code in detail yet, but I was wondering if this issue scylladb/gocql#161 will get resolved soon to avoid having to maintain the go.mod replace directives.

Unfortunately, it is going to be a long story, proper way to do that is to have next major release, which is going to take some time.
Also, it is going to be really easy to get rid of go.mod when scylladb/gocql finally get it's own package name.

@dkropachev
Copy link
Author

@mihaitodor , ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants