Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSYS2 support #912

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add MSYS2 support #912

wants to merge 5 commits into from

Conversation

taozuhong
Copy link

No description provided.

bjosv
bjosv reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@bjosv bjosv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, but I believe Windows builds of hiredis are best supported via CMake.
There has been some work recently regarding debug info and openssl support, and it also builds with MinGW/MSYS2.

Would it be acceptable to use CMake instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjosv bjosv bjosv left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taozuhong @bjosv