Remove dangling pointer dereference in RedisQtAdapter destructor #1230
+0
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destructor of RedisQtAdapter will be called AFTER the context has been freed.
At that point, m_ctx is a dangling pointer and should not be dereferenced.
See the valgrind output of the example-qt.cpp:
Nulling redisAsyncContext.ev.data at that point makes no sense anyway, since the context has been freed already.
So the proposed fix is to remove the offending code