-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added wiki pages to the repo #948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I am sorry I did not had time to take a look earlier. Thank you for your work and your PR!
I have started the review currently and it looks fine.
One question, is it necessary to clean up current Wiki page or do you have some experience with this gh action?
another question would be, are you able to point here in PR to changes/updates you did against current version of Wiki page, if any?
@djelinek
That's a good question, tbh I don't. It seemed to work on my fork once the wiki was created.
I intentionally didn't, in case the wiki is going to change until this PR is merged. I also need to copy the current wiki files into the repo again in case any changes happened since I started. |
|
@EcksDy could you please do a rebase and resolve a conflict with main? |
LGTM, thanks for the update |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Extracted wiki into a
wiki/
folder, as discussed in #887.Relevant changes are to the
main.yml
workflow.======
Before merging the PR: