Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getCodeLenses logic #903

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

unsortedhashsets
Copy link
Contributor

@unsortedhashsets unsortedhashsets commented Aug 9, 2023

Hi,

Changed logic:

  1. getCodeLenses, xpath changed from .//span[contains(@widgetid, 'codelens.widget')] to .//span[contains(@widgetid, 'codelens.widget')]/a[@id] to select all codelenses and not codelenses container
  2. CodeLens constructor changed from super(element.findElement(By.css('a')), editor); to super(element, editor);

So these changes should fix #902 reported bug

Check for new xpath ->
xpath-check


Before submitting your PR, please review the following checklist:

  • adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
    - DO make sure any public APIs changes are documented. No changes
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@unsortedhashsets unsortedhashsets added the ready-for-review Pull Request is Ready for Review label Aug 9, 2023
@unsortedhashsets unsortedhashsets force-pushed the 902 branch 2 times, most recently from b10118f to 80cd438 Compare August 22, 2023 09:19
@djelinek
Copy link
Collaborator

@unsortedhashsets it would be nice to also modify codelens provider (https://github.com/redhat-developer/vscode-extension-tester/blob/main/test/test-project/src/codelensProvider.ts) and tests to check also more codelens are now possible to work with

@unsortedhashsets
Copy link
Contributor Author

@unsortedhashsets it would be nice to also modify codelens provider (https://github.com/redhat-developer/vscode-extension-tester/blob/main/test/test-project/src/codelensProvider.ts) and tests to check also more codelens are now possible to work with

will try, thanks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@djelinek djelinek merged commit 09c6b4a into redhat-developer:main Aug 22, 2023
unsortedhashsets added a commit to unsortedhashsets/vscode-extension-tester that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Pull Request is Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] getCodeLenses method ignores codelenses in span after first
2 participants