Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retrieving quickpick items when using a multi-select quickpick #694

Conversation

ewanharris
Copy link
Contributor

@ewanharris ewanharris commented Mar 15, 2023

This is one attempt at a new API to solve #690, rather than using getQuickPicks to interact with a multi-select quickpick it introduces a new API getCheckboxes.

An alternative solution would be to make getQuickPicks take an argument specifying the quickpick as a multi-select such as getQuickPicks({ canSelectMany: true })

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@ewanharris ewanharris force-pushed the feat/support-interacting-with-multi-selects branch from 730a33d to 6d43212 Compare March 28, 2023 19:46
@ewanharris ewanharris force-pushed the feat/support-interacting-with-multi-selects branch from 6d43212 to 6991539 Compare April 17, 2023 20:46
@djelinek djelinek linked an issue May 30, 2023 that may be closed by this pull request
@djelinek djelinek marked this pull request as draft May 31, 2023 19:34
@djelinek
Copy link
Collaborator

djelinek commented Jun 7, 2023

I am not able to handle this PR as part of upcoming release, but I will do for next release. Marking this PR as prio for next PR review iteration.

@djelinek djelinek added the prio label Jun 7, 2023
@djelinek djelinek marked this pull request as ready for review September 15, 2023 07:49
@djelinek djelinek added the ready-for-review Pull Request is Ready for Review label Sep 15, 2023
@djelinek djelinek force-pushed the feat/support-interacting-with-multi-selects branch from 36c65f8 to f50ebce Compare October 4, 2023 12:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@djelinek djelinek merged commit ceda3c4 into redhat-developer:main Oct 4, 2023
12 checks passed
@ewanharris ewanharris deleted the feat/support-interacting-with-multi-selects branch October 4, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio ready-for-review Pull Request is Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Support interacting with quickpicks using canSelectMany
2 participants