Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add QuickInputButton support #1626

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feat: add QuickInputButton support #1626

merged 1 commit into from
Nov 19, 2024

Conversation

pospisilf
Copy link
Contributor

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@pospisilf pospisilf added the ready-for-review Pull Request is Ready for Review label Nov 18, 2024
@pospisilf pospisilf requested a review from djelinek November 18, 2024 18:54
djelinek
djelinek reviewed Nov 18, 2024
View reviewed changes
docs/Input.md Show resolved Hide resolved
tests/test-project/src/test/workbench/input.test.ts Outdated Show resolved Hide resolved
packages/page-objects/src/components/workbench/input/Input.ts Outdated Show resolved Hide resolved
@djelinek djelinek added the enhancement New feature or request label Nov 18, 2024
@djelinek djelinek linked an issue Nov 18, 2024 that may be closed by this pull request
[🚀 Request] Add QuickInputButton #1363
Closed
@pospisilf pospisilf force-pushed the issue-1363 branch 2 times, most recently from 22d6a99 to 9530ceb Compare November 19, 2024 07:48
@pospisilf pospisilf requested a review from djelinek November 19, 2024 08:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@djelinek djelinek merged commit 1af67fe into redhat-developer:main Nov 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djelinek djelinek djelinek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ready-for-review Pull Request is Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚀 Request] Add QuickInputButton
2 participants
@pospisilf @djelinek