Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add TextEditor.getBreakpoints(): Promise<Breakpoint[]> #1503

Merged
merged 1 commit into from
Aug 30, 2024
Merged

feat: Add TextEditor.getBreakpoints(): Promise<Breakpoint[]> #1503

merged 1 commit into from
Aug 30, 2024

Conversation

pospisilf
Copy link
Contributor

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@pospisilf pospisilf added enhancement New feature or request ready-for-review Pull Request is Ready for Review labels Aug 30, 2024
@pospisilf pospisilf requested a review from djelinek August 30, 2024 08:32
@pospisilf pospisilf linked an issue Aug 30, 2024 that may be closed by this pull request
[🚀 Request] Add TextEditor.getBreakpoints(): Promise<Breakpoint[]> #888
Closed
@pospisilf pospisilf force-pushed the issue-888 branch 2 times, most recently from 90772f9 to c6a8144 Compare August 30, 2024 08:40
@djelinek
Copy link
Collaborator

  • there is reported SonarCloud issue

image

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@djelinek djelinek merged commit 9221c0e into redhat-developer:main Aug 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djelinek djelinek djelinek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ready-for-review Pull Request is Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚀 Request] Add TextEditor.getBreakpoints(): Promise<Breakpoint[]>
2 participants
@pospisilf @djelinek