Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Modify terminal view tests to work also with zsh #1419

Merged
merged 1 commit into from
Jul 18, 2024
Merged

test: Modify terminal view tests to work also with zsh #1419

merged 1 commit into from
Jul 18, 2024

Conversation

djelinek
Copy link
Collaborator

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@djelinek djelinek marked this pull request as ready for review July 18, 2024 14:29
@djelinek djelinek merged commit 4213331 into redhat-developer:main Jul 18, 2024
11 checks passed
lgrossma pushed a commit to lgrossma/vscode-extension-tester that referenced this pull request Aug 1, 2024
@djelinek
test: Modify terminal view tests to work also with zsh (redhat-develo…
6862855 
…per#1419)

Signed-off-by: Dominik Jelinek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@djelinek