Skip to content

Commit

Permalink
chore(ci): enable tests on ubuntu 24.04
Browse files Browse the repository at this point in the history
Signed-off-by: Ondrej Dockal <[email protected]>
  • Loading branch information
odockal committed Oct 30, 2024
1 parent e8b2978 commit afa9af2
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 6 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ concurrency:

jobs:
coverage:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

env:
CODE_TYPE: stable
Expand Down Expand Up @@ -42,6 +42,8 @@ jobs:
- name: 📊 Run Tests with Coverage enabled
# 'set +e' and 'exit 0' - that means the workflow will not fail even the test failures are present. The failing tests are not directive for the code coverage reports itself
run: |
# allow unprivileged user namespace
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
set +e
xvfb-run --auto-servernum --server-args='-screen 0 1920x1080x24' npm run test:coverage
exit 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

check:
if: always()
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
name: 🚦 Status Check
needs: [test]
steps:
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/template-main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-24.04, macos-latest, windows-latest]
fail-fast: false

env:
Expand Down Expand Up @@ -52,12 +52,15 @@ jobs:
run: npm install --workspace=extester-test

- name: 🔍 Run Tests (macOS, windows)
if: matrix.os != 'ubuntu-latest'
if: matrix.os != 'ubuntu-24.04'
run: npm test

- name: 🔍 Run Tests (linux)
if: matrix.os == 'ubuntu-latest'
run: xvfb-run --auto-servernum --server-args='-screen 0 1920x1080x24' npm test
if: matrix.os == 'ubuntu-24.04'
run: |
# allow unprivileged user namespace
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
xvfb-run --auto-servernum --server-args='-screen 0 1920x1080x24' npm test
- name: 💾 Upload Screenshots
uses: actions/upload-artifact@v4
Expand Down

0 comments on commit afa9af2

Please sign in to comment.