Fix cluster-scoped runs within gitops-operator Rollouts E2E test script #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What does this PR do / why we need it:
As of latest release of Argo Rollouts, we now require CLUSTER_SCOPED_ARGO_ROLLOUTS_NAMESPACES to be set if user is installing outside the openshift-gitops Namespace.
This requirement broke the Rollouts E2E tests when running via the
run-rollouts-e2e-tests.sh
script in gitops-operator.The fix is to add/remove the appropriate value from the Subscription (or Deployment).
Code reviewer guidelines:
If you install OpenShift GitOps via subscription on clusterbot-style cluster, then run the script, it should pass.
The other mode (run via CI) isn't supported at the moment, as the Rollouts tests are not yet running as part of OpenShift CI (but hopefully soon!)