Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster-scoped runs within gitops-operator Rollouts E2E test script #816

Conversation

jgwest
Copy link
Collaborator

@jgwest jgwest commented Dec 2, 2024

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind failing-test

What does this PR do / why we need it:

As of latest release of Argo Rollouts, we now require CLUSTER_SCOPED_ARGO_ROLLOUTS_NAMESPACES to be set if user is installing outside the openshift-gitops Namespace.

This requirement broke the Rollouts E2E tests when running via the run-rollouts-e2e-tests.sh script in gitops-operator.

The fix is to add/remove the appropriate value from the Subscription (or Deployment).

Code reviewer guidelines:

If you install OpenShift GitOps via subscription on clusterbot-style cluster, then run the script, it should pass.

The other mode (run via CI) isn't supported at the moment, as the Rollouts tests are not yet running as part of OpenShift CI (but hopefully soon!)

@openshift-ci openshift-ci bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Dec 2, 2024
@openshift-ci openshift-ci bot requested review from chetan-rns and ciiay December 2, 2024 13:33
Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jgwest. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest
Copy link
Collaborator Author

jgwest commented Dec 2, 2024

/retest

Failed to run bundle: error waiting for CSV to install: timed out waiting for the condition\n"

@jparsai
Copy link
Collaborator

jparsai commented Dec 3, 2024

/lgtm @jgwest

@jgwest jgwest force-pushed the add-namespace-scoped-rollouts-test-nov-2024 branch from 2133204 to 23aa3cc Compare December 6, 2024 05:40
@jgwest
Copy link
Collaborator Author

jgwest commented Dec 9, 2024

One cluster init error, and one test flake in '1-069_validate_redis_secure_comm_autotls_ha' which I will submit a fix for.

/retest

@jgwest
Copy link
Collaborator Author

jgwest commented Dec 9, 2024

A flake in 1-045_validate_repo_exec_timeout which I will have a separate PR for

@jgwest
Copy link
Collaborator Author

jgwest commented Dec 9, 2024

/retest

@jgwest jgwest merged commit 0a059b3 into redhat-developer:master Dec 13, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a frequently failing test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants