Upgraded ArgoCD operator, ArgoCD to pick up the fix error when route api is not available #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test v4.14-kuttl-parallel |
|
/retest |
… being available Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
|
/test v4.13-kuttl-parallel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iam-veeramalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1f42107
into
redhat-developer:master
20 checks passed
trdoyle81
pushed a commit
to trdoyle81/gitops-operator
that referenced
this pull request
Aug 13, 2024
…api is not available (redhat-developer#761) * Upgraded ArgoCD operator, ArgoCD to pick up the fix for Route API not being available Signed-off-by: Anand Francis Joseph <[email protected]> * Reverted operator-sdk version to 1.35 Signed-off-by: Anand Francis Joseph <[email protected]> * fixed a failing test due to mount path mismatch Signed-off-by: Anand Francis Joseph <[email protected]> --------- Signed-off-by: Anand Francis Joseph <[email protected]>
4 tasks
2 tasks
ishitasequeira
pushed a commit
to ishitasequeira/gitops-operator
that referenced
this pull request
Nov 6, 2024
…api is not available (redhat-developer#761) * Upgraded ArgoCD operator, ArgoCD to pick up the fix for Route API not being available Signed-off-by: Anand Francis Joseph <[email protected]> * Reverted operator-sdk version to 1.35 Signed-off-by: Anand Francis Joseph <[email protected]> * fixed a failing test due to mount path mismatch Signed-off-by: Anand Francis Joseph <[email protected]> --------- Signed-off-by: Anand Francis Joseph <[email protected]> Signed-off-by: Ishita Sequeira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Upgraded ArgoCD Operator and ArgoCD to pick up the fix related to ArgoCD UI broken when the route API becomes unavailable momentarily.
When there is an issue with the API server pods, or the API server pods are just coming up after a restart, the current check for API availability done with a discovery client will fail. This makes the operator code to assume that the server does not support the Route API. To fix this, whenever the API availability check fails, the operator checks if the API is registered. If registered, then the operator assumes that the Route API is supported in the cluster and would eventually become available.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/GITOPS-4358
Test acceptance criteria:
How to test changes / Special notes to the reviewer: