Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'run-rollouts-e2e-tests.sh' should fail outright when an individual test fails #736

Merged

Conversation

jgwest
Copy link
Collaborator

@jgwest jgwest commented Jun 12, 2024

What type of PR is this?
/kind bug

What does this PR do / why we need it:

  • At present, the 'run-rollouts-e2e-tests.sh' script should fail when one of the child test suite fails
  • The 'set -e' check was missing which should have been present initially, I have added it

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Jun 12, 2024
@openshift-ci openshift-ci bot requested review from jaideepr97 and sbose78 June 12, 2024 14:37
Copy link

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jgwest. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest
Copy link
Collaborator Author

jgwest commented Jun 12, 2024

/retest

2 similar comments
@jgwest
Copy link
Collaborator Author

jgwest commented Jun 13, 2024

/retest

@jgwest
Copy link
Collaborator Author

jgwest commented Jun 13, 2024

/retest

Copy link
Member

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jgwest

/lgtm

@jgwest
Copy link
Collaborator Author

jgwest commented Jun 18, 2024

Thanks @chetan-rns!

@jgwest jgwest merged commit ea46ee9 into redhat-developer:master Jun 18, 2024
17 of 18 checks passed
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants