Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update controller-gen to v0.14.0 #697

Merged
merged 1 commit into from
May 9, 2024

Conversation

chetan-rns
Copy link
Member

What type of PR is this?

/kind cleanup

What does this PR do / why we need it:

The current version of controller-gen is not compatible with Go v1.22.1 and panics. This PR updates controller-gen version to v0.14.0.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from iam-veeramalla and trdoyle81 May 3, 2024 12:28
Copy link

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chetan-rns. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@saumeya saumeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Signed-off-by: Chetan Banavikalmutt <[email protected]>
@jgwest jgwest force-pushed the update-controller-gen branch from c0661ec to 09b575b Compare May 8, 2024 17:41
@chetan-rns
Copy link
Member Author

/retest

1 similar comment
@jgwest
Copy link
Collaborator

jgwest commented May 9, 2024

/retest

Copy link
Collaborator

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwest jgwest merged commit c6aff9e into redhat-developer:master May 9, 2024
17 of 18 checks passed
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants