-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed duplicate CRD entry for ArgoCD, updated missing details for operator owned crds #678
Removed duplicate CRD entry for ArgoCD, updated missing details for operator owned crds #678
Conversation
…Name for missing operator owned crds Signed-off-by: Anand Francis Joseph <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anandf - I think we also need to update config/manifests/bases/gitops-operator.clusterserviceversion.yaml. Code-gen will override bundle changes if they are not part of config/
directory.
Signed-off-by: Anand Francis Joseph <[email protected]>
@anandf: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tested out the changes. The ArgoCD CR is now visible in OCP developer console.
/cherry-pick v1.12 |
@svghadi: once the present PR merges, I will cherry-pick it on top of v1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
17bdd07
into
redhat-developer:master
@svghadi: new pull request created: #682 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick v1.11 |
@anandf: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick v1.11 |
@anandf: #678 failed to apply on top of branch "v1.11":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…_csv Removed duplicate CRD entry for ArgoCD, updated missing details for operator owned crds
What type of PR is this?
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/GITOPS-4513
Test acceptance criteria:
How to test changes / Special notes to the reviewer: