feat: Add tls cert mount for appset controller #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhesh Ghadi <[email protected]>
svghadi
requested review from
iam-veeramalla
and removed request for
chetan-rns and
wtam2018
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iam-veeramalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 17e173d
into
redhat-developer:master
1 check passed
trdoyle81
pushed a commit
to trdoyle81/gitops-operator
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Siddhesh Ghadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
argoproj-labs/argocd-operator#985 introduced support for custom tls cert mount into application set controller. This PR bring this change into gitops-operator.
Changes
spec.applicationSet.scmRootCaPathfield.Which issue(s) this PR fixes:
Fixes GITOPS-3107
How to test changes / Special notes to the reviewer:
Test instructions same as argoproj-labs/argocd-operator#985