Feature/red 556 less click grading #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed extra horizontal scroll (which was adding extra padding to the bottom) Fixed page always have a scroll Fixed Assignment / User selection always having a scroll
.gitignore
Outdated
| @@ -22,5 +22,5 @@ | |||
| npm-debug.log* | |||
| yarn-debug.log* | |||
| yarn-error.log* | |||
| .vscode/* | |||
| # .vscode/* | |||
There was a problem hiding this comment.
Remove don't comment!
| } | ||
|
|
||
| if (_.isEmpty(topic.questions)) { | ||
| logger.error('GradingPage: nextProblem: empty questions'); |
There was a problem hiding this comment.
If the button is shown under these conditions, we should show users an error.
| } else { | ||
| const problemIndex = _.findIndex(topic.questions, ['id', problemId]); | ||
| if (problemIndex < 0) { | ||
| logger.warn('GradingPage: nextProblem: problem not found'); |
There was a problem hiding this comment.
Should this jump out and show the user an error?
| > | ||
| Previous Problem | ||
| </Button> | ||
| <Button |
There was a problem hiding this comment.
Should this be hidden for students?
PanopticaRising
previously approved these changes
Apr 28, 2021
PanopticaRising
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.