Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 #985

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Add support for Python 3.13 #985

wants to merge 19 commits into from

Conversation

chriskuehl
Copy link
Member

@chriskuehl chriskuehl commented Sep 27, 2024

Python 3.13 was released on 2024-10-07. This PR adds support to Baseplate.py for services running 3.13.

Merge checklist

  • Replace rc2 with final 3.13.0 release once it's available
  • Need wheels for some libraries (incomplete list):
    • psycopg2: https://github.com/psycopg/psycopg2/pull/1695
    • confluent-kafka: https://github.com/confluentinc/confluent-kafka-python/issues/1768
    • pendulum: https://github.com/sdispater/pendulum/issues/844
      • No wheel yet, so Rust needs to be available at install time. We'll include this in the release notes but don't want to block this branch on it, especially since it can be worked around (e.g. by building your own local wheel ahead of time).
  • gevent is not yet compatible with 3.13, work is in progress: https://github.com/gevent/gevent/commits/py313/
  • Review dependencies manually for issues like we did for 3.11/3.12

@chriskuehl
Copy link
Member Author

We're hitting https://github.com/pylint-dev/pylint/issues/10112 now.

@chriskuehl chriskuehl changed the title [WIP] Add support for Python 3.13 Add support for Python 3.13 Dec 19, 2024
@chriskuehl chriskuehl marked this pull request as ready for review December 19, 2024 16:23
@chriskuehl chriskuehl requested a review from a team as a code owner December 19, 2024 16:23
- name: Install temporary Python 3.13 build dependencies
if: ${{ matrix.python-version == '3.13' }}
run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call me old fashioned, but it seems like a good idea to install a specific version and verify checksums.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 yeah how long do we expect this workaround to be in place?

- name: Install temporary Python 3.13 build dependencies
if: ${{ matrix.python-version == '3.13' }}
run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 yeah how long do we expect this workaround to be in place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants