provider-server: inform storage-client to enforce host NW on CSI #2884
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohan47 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
do-not-merge/work-in-progress
|
Hi @rohan47. Thanks for your PR. I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
obnoxxx
added
the
ok-to-test
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
services/provider/server/server.go
Outdated
| return &pb.OnboardConsumerResponse{StorageConsumerUUID: storageConsumerUUID}, nil | ||
| enforceHostNWCSI := false | ||
| addressRanges := rookCephv1.AddressRangesSpec{} | ||
| if storageCluster.Spec.HostNetwork && storageCluster.Spec.Network.AddressRanges != &addressRanges { |
There was a problem hiding this comment.
why do you need to compare pointers here?
when using a dedicated network for ocs, provider needs to inform storageclient to enforce host network for all csi pods Signed-off-by: Rohan Gupta <[email protected]>
rohan47
force-pushed
the
host_network_csi
branch
from
560cae0 to
44228af
Compare
openshift-ci
bot
removed
the
needs-ok-to-test
|
@ezio-auditore: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
when using a dedicated network for ocs, provider needs to inform storageclient to enforce host network for all csi pods