Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Handle crash on nullable intersection on ClosureReturnTypeRector #6213

Merged
merged 2 commits into from
Aug 2, 2024
Merged

[TypeDeclaration] Handle crash on nullable intersection on ClosureReturnTypeRector #6213

merged 2 commits into from
Aug 2, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Aug 2, 2024 •
edited
Loading

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @grambas

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit b0e67ab into main Aug 2, 2024
34 checks passed
@samsonasik samsonasik deleted the handle-nullable-intersection branch August 2, 2024 12:30
@grambas
Copy link

grambas commented Aug 2, 2024

Fixed 🎉 /cc @grambas

nice job, that was fast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class property as return in willReturnCallback throws an exception
2 participants
@samsonasik @grambas