Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeQuality] Remove MoveVariableDeclarationNearReferenceRector for too wide domain, not capable on most of real projects #587

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Aug 3, 2021

No description provided.

samsonasik added a commit to codeigniter4/CodeIgniter4 that referenced this pull request Aug 3, 2021
@TomasVotruba TomasVotruba changed the title tv more near [CodeQuality] Remove MoveVariableDeclarationNearReferenceRector for too wide domain, not capable on most of real projects Aug 3, 2021
@TomasVotruba
Copy link
Member Author

First, thank you @samsonasik for a lot of effort you put into this rule. I really appreciate it and you helped to cleanup lot of our code.

Seeing so many fixes, this rule seems a bit magical to me and waiting to be broken in another assumption, like references variable in the top and used above the method call etc.

Also, seeing issues like https://twitter.com/frankdejonge/status/1419577807823384576, I think we should refocus our energy from "bleeding rules" to improve DX in general. Make 450 rules more accesible to everyone by better experience, rather then invest same amount of energy to 2-3 magical rules that very few developers can use without being affraid to break their code base.

Saying that, I'd be for removing this rule and focus on more generics sets that everyone can use 👍

@samsonasik
Copy link
Member

@TomasVotruba yes, it is ok. It was used by CodeIgniter4 project. I removed it from the rector config at codeigniter4/CodeIgniter4@c5c33c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants