Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Skip assign in construct with method call property same name on RestoreDefaultNullToNullableTypePropertyRector #5556

Merged
merged 1 commit into from
Feb 4, 2024
Merged

[TypeDeclaration] Skip assign in construct with method call property same name on RestoreDefaultNullToNullableTypePropertyRector #5556

merged 1 commit into from
Feb 4, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik
[TypeDeclaration] Skip assign in construct with method call property …
c568e2e 
…same name on RestoreDefaultNullToNullableTypePropertyRector
@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @kamil-tekiela

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it;)

@samsonasik samsonasik merged commit 2dd3951 into main Feb 4, 2024
41 checks passed
@samsonasik samsonasik deleted the skip-property-same-name branch February 4, 2024 20:44
@TomasVotruba
Copy link
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of RestoreDefaultNullToNullableTypePropertyRector
2 participants
@samsonasik @TomasVotruba