Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Change bool to false or true docblock when union has false/true standalone type on ReturnUnionTypeRector #5543

Merged
merged 2 commits into from
Feb 2, 2024
Merged

[TypeDeclaration] Change bool to false or true docblock when union has false/true standalone type on ReturnUnionTypeRector #5543

merged 2 commits into from
Feb 2, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Feb 2, 2024 •
edited
Loading

To avoid phpstan error after return type added:

79     PHPDoc tag @return with type array|bool is not subtype of native type  
         array|false.

Fixes rectorphp/rector#8450

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik samsonasik changed the title [TypeDeclaration] Change bool to false or true docblock when union has false/true standalone type [TypeDeclaration] Change bool to false or true docblock when union has false/true standalone type on ReturnUnionTypeRector Feb 2, 2024
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it;)

@samsonasik samsonasik merged commit cdc5723 into main Feb 2, 2024
41 checks passed
@samsonasik samsonasik deleted the false-bool branch February 2, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of ReturnUnionTypeRector
1 participant
@samsonasik