[Php80] Handle parent with typed param on AddParamBasedOnParentClassMethodRector

[samsonasik]

When parent class has typed param:

class A
{
    public function foo(int $foo)
    {
        
    }
}

class B extends A
{
    public function foo()
    {
        
    }
}

It currently produce internal php-parser error:

1) Rector\Tests\Php80\Rector\ClassMethod\AddParamBasedOnParentClassMethodRector\AddParamBasedOnParentClassMethodRectorTest::test with data set #10 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
assert($startPos >= 0 && $endPos >= 0) in /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/PrettyPrinterAbstract.php:535

this PR try to solve it.

[samsonasik]

I think the solution is when parent has type, child should not has type so it safe to apply, ref https://3v4l.org/4Mgrt

[samsonasik]

When user wants it to work on php 7.1 too, there is DowngradeParameterTypeWideningRector rule for it to remove type hint in parent.

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[samsonasik]

rebased.

[TomasVotruba]

When user wants it to work on php 7.1 too, there is DowngradeParameterTypeWideningRector rule for it to remove type hint in parent.

That would not work now, as the interface must be explicitly mentioned as unsafe.

[TomasVotruba]

assert($startPos >= 0 && $endPos >= 0) in /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/PrettyPrinterAbstract.php:535

These errors usually means that node reprint of original tokens failed. PhpParser tried to keep original formatting and guesses the original position of tokens. Sometimes the node changes, but tokens don't refresh.

The $node->set(AttributeKey::ORIGINAL_NODE, null) on related node usually helps.

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

Note:

• The $this->print() is only removable on this PR (add type hint) as it can get the name of type hint via NodeNameResolver.

• The $this->print() still left over for set default value for PR [Php80] Handle param with default value on AddParamBasedOnParentClassMethodRector #1452 as valueResolver cannot always get the correct value of it, and without it, it got error assert($startPos >= 0 && $endPos >= 0)

[TomasVotruba]

I've added commit that include the original node example that I meant. See if it's ok

[samsonasik]

@TomasVotruba thank you, that solve it, I moved to separate method to fix phpstan a200007

[samsonasik]

Close-reopen to restart CI build

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[TomasVotruba]

Thank you 👍