Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DowngradePhp74] Add DowngradeReflectionGetTypeRector #1407

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Dec 6, 2021

@TomasVotruba TomasVotruba force-pushed the tv-downgrade-reflection-gettype branch 2 times, most recently from 5adf0e2 to c6ea14f Compare December 6, 2021 12:53
@TomasVotruba TomasVotruba force-pushed the tv-downgrade-reflection-gettype branch from 5735849 to 81c6e62 Compare December 6, 2021 13:02
@TomasVotruba TomasVotruba merged commit 13943fd into main Dec 6, 2021
@TomasVotruba TomasVotruba deleted the tv-downgrade-reflection-gettype branch December 6, 2021 16:26
@samsonasik
Copy link
Member

@TomasVotruba it seems it cause downgrade scoped error:

https://github.com/rectorphp/rector-src/runs/4433091788?check_suite_focus=true#step:14:76

------------------------------------------------------------
2021-12-06T16:42:46.4167654Z Parse error: rector-prefixed-downgraded/src/NodeAnalyzer/PropertyPresenceChecker.php:107
2021-12-06T16:42:46.4168783Z     105|             return null;
2021-12-06T16:42:46.4169266Z     106|         }
2021-12-06T16:42:46.4169901Z   > 107|         if (!null instanceof \ReflectionNamedType) {
2021-12-06T16:42:46.4170553Z     108|             return null;
2021-12-06T16:42:46.4171023Z     109|         }
2021-12-06T16:42:46.4172695Z Instanceof expects an object instance, constant given in rector-prefixed-downgraded/src/NodeAnalyzer/PropertyPresenceChecker.php on line 107
2021-12-06T16:42:46.4299950Z ##[error]Process 

@TomasVotruba
Copy link
Member Author

Thanks for noticing 👍 I'll check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants