Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DowngradePhp80/81] Refactor Downgrade Resource Return to Object to use BooleanOr check #1193

Merged
merged 6 commits into from
Nov 8, 2021
Merged

[DowngradePhp80/81] Refactor Downgrade Resource Return to Object to use BooleanOr check #1193

merged 6 commits into from
Nov 8, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 8, 2021 •
edited
Loading

Ensure to have the following behaviour :

-$obj instanceof \CurlHandle;
+is_resource($obj) || $obj instanceof \CurlHandle;

to keep code before and after downgraded working when used in upper php version.

@samsonasik samsonasik merged commit 85c3848 into main Nov 8, 2021
@samsonasik samsonasik deleted the refactor-downgrade-object-to-resource branch November 8, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik