[DowngradePhp74] Add DowngradePreviouslyImplementedInterfaceRector #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
add-downgrade-previously-implemented-interface
branch
from
e8161b8 to
6569369
Compare
samsonasik
force-pushed
the
add-downgrade-previously-implemented-interface
branch
from
0a411cf to
1424056
Compare
samsonasik
force-pushed
the
add-downgrade-previously-implemented-interface
branch
from
7d80060 to
898c73b
Compare
samsonasik
force-pushed
the
add-downgrade-previously-implemented-interface
branch
from
9b11895 to
daa6bff
Compare
samsonasik
force-pushed
the
add-downgrade-previously-implemented-interface
branch
from
7f3fdc0 to
e4bb145
Compare
|
implemented 🎉 |
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Looks good to me, good job with tests 👍 |
TomasVotruba
deleted the
add-downgrade-previously-implemented-interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is new psr/container release that adds
extends ThrowableonContainerExceptionInterfacethat make error on existing scoped build: https://github.com/rectorphp/rector-src/runs/4119669391?check_suite_focus=true#step:22:6Ref:
This new Rule try to solve it by remove the next interface if already included in previous interface.
Resolve rectorphp/rector#6787