[CodingStyle] Remove RemoveUnusedAliasRector, job rather for coding standard tool and opinonated #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g standard tool and opinonated
TomasVotruba
force-pushed
the
tv-depre-short-alias
branch
from
f3167cb to
d162e5b
Compare
TomasVotruba
force-pushed
the
tv-depre-short-alias
branch
from
d162e5b to
5088198
Compare
TomasVotruba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After many complex failed efforts to make this rule work #1148, #1149, #1147, #1146, to make PHPStan parser work #1144, it's time to rethign this rule.
Complexity with aliasesed, same-named, conflicting short/class names is enormous and maybe Rector is not quite right tool to handle coding standards. Also, some uses prefer to keep alias for better readability :)
Using this rule goes agains subjective descissions. It is similar to removal of
MoveVariableDeclarationNearReferenceRectorfor high complexity and very unrealiable behavior in the practise.Ref #900
Saying that, this rule should be deprecated to keep Rector in more reliable scope and let users decide better, mabye with PHPStan rule, how such code should be refacoted.