Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

feat: Drop Old Context API #17

Merged
merged 4 commits into from
Dec 3, 2019
Merged

Conversation

MaxMEllon
Copy link

@MaxMEllon MaxMEllon commented Dec 3, 2019

概要

fixed: #11

  • old context api と new context api が混在していたのを修正
  • react-redux-analytics では old context api を使っている
  • react-redux は version 6 以降で 新しい context api を使っている

react-redux-analytucs を使っていると react-redux がバージョンを上げることができない

備考

@MaxMEllon MaxMEllon changed the title feat: Drop Old Context API WIP: feat: Drop Old Context API Dec 3, 2019
@MaxMEllon MaxMEllon changed the title WIP: feat: Drop Old Context API feat: Drop Old Context API Dec 3, 2019
@MaxMEllon
Copy link
Author

@takanashi-recruit @yosuke-furukawa レビューお願いします!

@yosuke-furukawa
Copy link
Member

LGTM

@nassyemon
Copy link
Contributor

Good.

@yosuke-furukawa yosuke-furukawa merged commit e61d548 into recruit-tech:master Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work with react-redux v6
3 participants