Upgrade to HEAD of Realm Core's master #6637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
added
no-changelog
no-jira-ticket
kraenhansen
reviewed
Apr 25, 2024
kraenhansen
reviewed
Apr 25, 2024
kraenhansen
reviewed
Apr 25, 2024
kraenhansen
reviewed
Apr 25, 2024
kraenhansen
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Looks like a lot of good simplifications. If it passes tests I'm fine with merging it as part of an upgrade to Core 👍
In most cases the downcasting has no effect but for the user classes
🤞 We didn't test the performance of this, right? I mean - its a pretty critical code path.
I have changed it so we don't downcast but I hope that a C++ compiler will generate very little code for Foo *foo = new Foo();
auto bar = std::dynamic_pointer_cast<Foo>(foo); |
Co-authored-by: Kræn Hansen <[email protected]>
elle-j
reviewed
Apr 26, 2024
| }, | ||
| ); | ||
| userAgentBindingInfo: App.userAgent, | ||
| } |
There was a problem hiding this comment.
Linting 👍
Suggested change
| } | |
| }, |
papafe
added a commit
that referenced
this pull request
May 23, 2024
* main: (22 commits) Prepare for vNext (#6677) [12.9.0] Bump version (#6676) Fix performance tests (#6665) Combined: Support `Mixed` data type with collections (#6613) Update expected error messages (#6674) Adding --latest-local to the baas test server CLI (#6673) Upgrade to Realm Core v14.7.0 (#6663) Upgrade @trunk/launcher to v1.3.1 to support Apple's versioning scheme for macOS (#6671) Prepare for vNext (#6669) [12.8.1] Bump version (#6668) Use unreleased core (#6667) Fix realm/react changelog (#6661) Fix GHA error when publishing package release (#6660) Prepend vNext to realm/react changelog. [realm-react-0.7.0] Bump version (#6658) Update OAuth2Helper to remove accessing the stitch prefix (#6659) Fix unresolvable links in API reference docs and remove re-exports (#6646) Prepare for vNext (#6645) [12.8.0] Bump version (#6643) Upgrade to HEAD of Realm Core's master (#6637) ... # Conflicts: # CHANGELOG.md # integration-tests/tests/src/tests/mixed.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Next core release will come with a number of breaking changes. This PR is a preparation for the release, and it requires realm/realm-core#7623 to be merged and release.
The Binding Generator has some limitations, and in conjunction with realm/realm-core#7623 this PR works around them.
In realm/realm-core#7300, a new user is introduced (
app::User) which inherit fromSyncUser. As both classes are used withstd::shared_ptr(annotatedSharedPtrWrapperinspec.xml), it is not possible to generate code. Thesolutionhack is to downcast all objects. In most cases the downcasting has no effect but for the user classes. For user classes we will use only one -app::User- and downcastSyncUsertoapp::User.☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary