Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SwiftVersion to support numeric version comparisons #5526

Merged

Conversation

chandlerwall
Copy link
Contributor

@chandlerwall chandlerwall commented Apr 4, 2024

Fixes #5517

TODO

@SwiftLintBot
Copy link

SwiftLintBot commented Apr 4, 2024

17 Messages
📖 Linting Aerial with this PR took 0.82s vs 0.82s on main (0% slower)
📖 Linting Alamofire with this PR took 1.14s vs 1.16s on main (1% faster)
📖 Linting Brave with this PR took 6.75s vs 6.58s on main (2% slower)
📖 Linting DuckDuckGo with this PR took 3.47s vs 3.48s on main (0% faster)
📖 Linting Firefox with this PR took 9.27s vs 9.32s on main (0% faster)
📖 Linting Kickstarter with this PR took 8.1s vs 8.18s on main (0% faster)
📖 Linting Moya with this PR took 0.49s vs 0.48s on main (2% slower)
📖 Linting NetNewsWire with this PR took 2.45s vs 2.42s on main (1% slower)
📖 Linting Nimble with this PR took 0.71s vs 0.69s on main (2% slower)
📖 Linting PocketCasts with this PR took 6.94s vs 6.97s on main (0% faster)
📖 Linting Quick with this PR took 0.33s vs 0.33s on main (0% slower)
📖 Linting Realm with this PR took 4.02s vs 4.09s on main (1% faster)
📖 Linting Sourcery with this PR took 2.08s vs 2.06s on main (0% slower)
📖 Linting Swift with this PR took 3.93s vs 3.96s on main (0% faster)
📖 Linting VLC with this PR took 1.14s vs 1.11s on main (2% slower)
📖 Linting Wire with this PR took 14.42s vs 14.23s on main (1% slower)
📖 Linting WordPress with this PR took 9.61s vs 9.63s on main (0% faster)

Generated by 🚫 Danger

@SimplyDanny
Copy link
Collaborator

Are you going to continue here, @chandlerwall?

@SimplyDanny SimplyDanny force-pushed the SwiftVersion_numeric_comparable branch from fe59e70 to 0b6be0d Compare May 1, 2024 15:41
@SimplyDanny SimplyDanny marked this pull request as ready for review May 1, 2024 15:45
@SimplyDanny SimplyDanny merged commit 16cb4a0 into realm:main May 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swiftlint analyze appears to stop collecting after 12 files with Swift 5.10
3 participants