Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post: deprecate config files without sphinx or mkdocs configuration #342

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 12, 2024

@stsewd stsewd requested a review from a team as a code owner December 12, 2024 21:04
@stsewd stsewd requested a review from ericholscher December 12, 2024 21:04
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I thought we were also defaulting to Sphinx and find config even if you didn't even specify the sphinx: key, right? Will be good to remove that magic.

@stsewd
Copy link
Member Author

stsewd commented Dec 13, 2024

I thought we were also defaulting to Sphinx and find config even if you didn't even specify the sphinx: key, right? Will be good to remove that magic.

Yeah, that's also part of the deprecation.

Comment on lines +45 to +47
- **Monday, January 6, 2025**: Temporarily disallow building projects for 12 hours, from 00:01 PST to 11:59 PST.
- **Monday, January 20, 2025**:Temporarily disallow building projects for 24 hours, from 00:01 PST to 23:59 PST.
- **Monday, February 3, 2025**: Permanently disallow building projects.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move faster here. This deprecation is very small and it's pretty easy to adapt those YAML files. That will allow us to deploy build.jobs.build.html quicker and support workflows people have been trying to run on Read the Docs and they are currently using hacky approaches.

Suggested change
- **Monday, January 6, 2025**: Temporarily disallow building projects for 12 hours, from 00:01 PST to 11:59 PST.
- **Monday, January 20, 2025**:Temporarily disallow building projects for 24 hours, from 00:01 PST to 23:59 PST.
- **Monday, February 3, 2025**: Permanently disallow building projects.
- **Monday, January 6, 2025**: Temporarily disallow building projects for 12 hours, from 00:01 PST to 11:59 PST.
- **Monday, January 13, 2025**:Temporarily disallow building projects for 24 hours, from 00:01 PST to 23:59 PST.
- **Monday, January 20, 2025**: Permanently disallow building projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants