Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "external link" icon on blog, and put it at top of resources #283

Merged
merged 2 commits into from
May 20, 2024

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented May 14, 2024

@ericholscher ericholscher requested a review from a team as a code owner May 14, 2024 20:13
@ericholscher ericholscher requested a review from agjohnson May 14, 2024 20:13
@agjohnson
Copy link
Contributor

The change looks okay technically, but I think the user is much more likely to click through to documentation, support, or our tutorial. This is the reason they are at the top of the list currently, which still feels correct.

@ericholscher ericholscher merged commit e32c94f into main May 20, 2024
3 of 4 checks passed
@ericholscher ericholscher deleted the blog-internal branch May 20, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants