-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed APIv3: use latest embed API version #146
Changes from all commits
e375975
c04238c
bdc8e1d
68b16b4
51760a5
fea2a5b
e463808
a4d0aaf
64f7d3d
5cfbc3b
56beaf4
171920a
0096aee
af03ce8
e17b9b7
128a491
1b7787a
a99bb7b
8b0c706
6532887
cf1c8b2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
version: 2 | ||
|
||
python: | ||
version: 3 | ||
version: "3.8" | ||
install: | ||
- method: pip | ||
path: . | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -101,8 +101,9 @@ These settings are global and have effect on both, tooltips and modal dialogues. | |
|
||
.. warning:: | ||
|
||
The Sphinx's target project **must be hosted on Read the Docs** to work. | ||
This is a current limitation that we hope to remove in the future. | ||
The Sphinx's target project **must be hosted on Read the Docs** to work or, | ||
be one of the allowed external projects: | ||
currently CPython, SymPy, NumPy are supported. | ||
|
||
.. confval:: hoverxref_intersphinx_types | ||
|
||
|
@@ -152,33 +153,16 @@ These settings are global and have effect on both, tooltips and modal dialogues. | |
.. _Mathjax: http://www.sphinx-doc.org/es/master/usage/extensions/math.html#module-sphinx.ext.mathjax | ||
|
||
|
||
.. warning:: | ||
|
||
You shouldn't modify the following three settings (api_host, project, version) unless you know what you are doing. | ||
Their defaults should be fine to build the documentation and make it work in Read the Docs. | ||
|
||
|
||
.. confval:: hoverxref_api_host | ||
|
||
Description: Host URL for the API to retrieve the content of the floating window | ||
|
||
Default: ``https://readthedocs.org`` | ||
|
||
Type: string | ||
|
||
.. confval:: hoverxref_project | ||
|
||
Description: Read the Docs project slug | ||
|
||
Default: It defaults to ``READTHEDOCS_PROJECT`` environment variable | ||
|
||
Type: string | ||
|
||
.. confval:: hoverxref_version | ||
.. warning:: | ||
|
||
Description: Read the Docs version slug | ||
You shouldn't modify this setting unless you know what you are doing. | ||
Its default should be fine to build the documentation and make it work in Read the Docs. | ||
|
||
Default: It defaults to ``READTHEDOCS_VERSION`` environment variable | ||
Default: ``https://readthedocs.org`` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How are we planning to support this on .org & .com? Should we do this automagically, or just always default to .org? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hrm... good question! I haven't thought about this, honestly. I don't think we have a way to differentiate if we are running in .org or .com from the builder. It may be good to expose an environment variable? In that case, we can use it to differentiate. Actually... I just remembered that @stsewd already mentioned this in #134 --so, we should probably continue the conversation there, finish that PR, and merge it. I think it was good, but there was an issue with CORS that I don't remember where we ended up. |
||
|
||
Type: string | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this value get pulled from the environment, so other people can use it if needed in dev? eg
NGROK_HOVERXREF= https://foo.ngrok.io
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha! Yes! I don't know why I didn't do it like you are suggesting originally 🙃 It should probably just use
hoverxref_api_host
all in uppercase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that I hardcoded it here so I don't have to remember the different URL options 😄