Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set brownouts for deprecated embed API v2 #11786

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Set brownouts for deprecated embed API v2 #11786

merged 2 commits into from
Nov 25, 2024

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Nov 21, 2024

Ref #10677

@stsewd stsewd requested a review from a team as a code owner November 21, 2024 17:49
@stsewd stsewd requested a review from humitos November 21, 2024 17:49
humitos
humitos approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is a typo on one of the dates, tho

readthedocs/embed/views.py Outdated Show resolved Hide resolved
readthedocs/embed/views.py Outdated Show resolved Hide resolved
@stsewd stsewd merged commit 6711656 into main Nov 25, 2024
8 checks passed
@stsewd stsewd deleted the deprecate-embed-api-v2 branch November 25, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees

@stsewd stsewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @humitos