Search: remove non-generic parser code #10676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #10272. We can't remove the code that generates the fjson files, since they are being used by the embed API (v2), that API is mentioned as deprecated, we should do the actual deprecation by contacting projects using it.
stsewd
requested review from
humitos
and removed request for
a team and
agjohnson
humitos
approved these changes
Aug 31, 2023
| @@ -1,7 +1,20 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
I understand the HTML files has to be valid HTML now to be able to parse them, right?
There was a problem hiding this comment.
yeah, previously these were just an extract of the full document.
Comment on lines
+2
to
+3
| "path": "autodoc.html", | ||
| "title": "sphinx.ext.autodoc – Include documentation from docstrings", |
There was a problem hiding this comment.
I'm not sure to understand why these are now returned and they weren't before. Can you expand on that?
There was a problem hiding this comment.
Previously the title and path came from the fjson file, now they come from the file itself.
Co-authored-by: Manuel Kaufmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10272.
We can't remove the code that generates the fjson files, since they are being used by the embed API (v2),
that API is mentioned as deprecated,
we should do the actual deprecation by contacting
projects using it.
I went ahead and removed the piece of code of the mkdocs embed API, since it was trying to query fjson files for those projects, but we stopped generating those files for mkdocs a long time ago...