Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and update for new dashboard pointers #524

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Fixes and update for new dashboard pointers #524

merged 5 commits into from
Nov 12, 2024

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Nov 9, 2024 •
edited
Loading

  • Add new dashboard announcement template
  • Fix issues around spacing of top notifications
  • Drop unused block on build detail page

1cfe710 is a linting step

  • Update blog url

@agjohnson agjohnson mentioned this pull request Nov 9, 2024
Merged
@agjohnson agjohnson marked this pull request as ready for review November 12, 2024 07:02
@agjohnson agjohnson requested a review from a team as a code owner November 12, 2024 07:02
@agjohnson agjohnson requested a review from humitos November 12, 2024 07:02
humitos
humitos approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

It renders as follows:

Screenshot_2024-11-12_13-52-16

@humitos humitos merged commit dd575fe into main Nov 12, 2024
4 checks passed
@humitos humitos deleted the agj/new-dashboard-notification branch November 12, 2024 12:59
humitos pushed a commit to readthedocs/readthedocs.org that referenced this pull request Nov 12, 2024
@agjohnson
Fix site-wide new dashboard notification (#11543)
7bceb65 
Notification on new dashboard:


![image](https://github.com/user-attachments/assets/1cc4c608-94c3-4a2f-bab1-6e4622fe6c72)

Notification on old dashboard:


![image](https://github.com/user-attachments/assets/3dbe24a1-9597-418c-82b7-c7962f2c969b)

----

- Fixes #11209
- Requires readthedocs/ext-theme#524
- Refs readthedocs/website#335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agjohnson @humitos