feat: support react 18 #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
reviewed
Apr 5, 2024
kellyjosephprice
commented
Apr 5, 2024
| }); | ||
|
|
||
| it('should add an overlay to non-highlighted in lines when ranges are applied', () => { | ||
| expect(node.find('.cm-linerow.cm-overlay')).toHaveLength(6); | ||
| const { container } = defaultRender(); | ||
| expect(container.querySelectorAll('.cm-linerow.cm-overlay')).toHaveLength(3); |
There was a problem hiding this comment.
I have no idea how this was working before?
kellyjosephprice
force-pushed
the
feat/support-react-18
branch
from
19932e6 to
68a696e
Compare
erunion
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Some repo maintenance!
I came to check for React 18 support, and ended up swapping out
enzymefor@testing-library. Some of the tests are not exactly the same, but I think it's ok.🧬 QA & Testing
Verify that the adapted tests seem reasonable?