feat: adding support for node 18, dropping node 12 #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like husky cannot be found on node 14 or 18:
|
I think we were reliant on buggy behaviour in npm@7 where `npm ci` wasn't running some of the lifecycle hooks: npm/cli#1905 (comment) This got fixed in npm@8 but now our CI process breaks: npm/cli@d825e90 Decided to follow the recommendations from husky's docs to do this so it doesnt run the `prepare` step: ```sh npm ci --ignore-scripts ``` https://github.com/typicode/husky/blob/0bcdac6b4dad6eedecc49cf3837ecc05b321db2e/docs/README.md#disable-husky-in-cidockerprod=
domharrington
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
Node 18 came out yesterday so I'm changing our engines list to support everything from Node 14 and on, dropping support for Node 12 in the process (which is being EOL'd in 10 days).
🧬 Testing
Tests on Node 18 should be passing.