Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): general maintenance #186

Merged
merged 13 commits into from
Jun 29, 2021
Merged

chore(deps): general maintenance #186

merged 13 commits into from
Jun 29, 2021

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented Jun 25, 2021

🧰 Changes

This PR removes some packages, updates some, and updates what versions of node CI is run against. node v10 has been EOL for about 2 months.

The following packages have been removed as their newer replacement is already installed:

  • remove babel-core
  • remove babel-eslint
  • remove babel-polyfill

🧬 QA & Testing

@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-186 June 25, 2021 17:57 Inactive
@kellyjosephprice kellyjosephprice changed the title deps: Remove old/redundant debs build: remove old/redundant debs Jun 25, 2021
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-186 June 25, 2021 18:12 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-186 June 25, 2021 19:54 Inactive
@kellyjosephprice kellyjosephprice changed the title build: remove old/redundant debs build: general maintenance Jun 25, 2021
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-186 June 25, 2021 21:17 Inactive
@kellyjosephprice kellyjosephprice changed the title build: general maintenance chore(deps): general maintenance Jun 25, 2021
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-186 June 25, 2021 21:38 Inactive
@kellyjosephprice kellyjosephprice requested review from a team, erunion and rafegoldberg and removed request for a team June 25, 2021 22:00
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-186 June 25, 2021 22:01 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-186 June 25, 2021 22:13 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-186 June 25, 2021 22:13 Inactive
@@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
node-version: [12.x, 14.x, 16.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the release workflow too, it's still on Node 10: https://github.com/readmeio/markdown/blob/next/.github/workflows/release.yml#L15

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks!

package.json Outdated Show resolved Hide resolved
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-186 June 29, 2021 16:31 Inactive
@kellyjosephprice kellyjosephprice merged commit c2c59b7 into next Jun 29, 2021
@kellyjosephprice kellyjosephprice deleted the deps/audit branch June 29, 2021 16:38
rafegoldberg pushed a commit that referenced this pull request Jun 29, 2021
## Version 6.28.0-next.1

### ✨ New & Improved

* adopt variable ([#200](#200)) ([947e31e](947e31e))

### 🛠 Fixes & Updates

* **deps-dev:** bump @readme/variable from 11.0.0 to 13.4.12 ([#188](#188)) ([16724d8](16724d8))
* **deps-dev:** bump babel-jest from 26.6.3 to 27.0.5 ([#187](#187)) ([dd26212](dd26212))
* **deps-dev:** bump eslint from 7.19.0 to 7.29.0 ([#184](#184)) ([7e032cf](7e032cf))
* **deps-dev:** bump puppeteer from 9.1.1 to 10.0.0 ([#191](#191)) ([3218a8d](3218a8d))
* **deps:** bump unist-util-select from 3.0.4 to 4.0.0 ([#180](#180)) ([caa51ff](caa51ff))
* **deps:** general maintenance ([#186](#186)) ([c2c59b7](c2c59b7))
* updatee package-log.json ([59e2df2](59e2df2))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.28.0-next.1

rafegoldberg pushed a commit that referenced this pull request Jun 29, 2021
## Version 6.28.0

### 📘 Tests & Docs

* add category to each page ([#171](#171)) ([9a5e1c6](9a5e1c6))
* remove unnecessary slug parameter, newlines ([8e0ac53](8e0ac53)), closes [/github.com//pull/173#issuecomment-867169250](https://github.com/readmeio//github.com/readmeio/markdown/pull/173/issues/issuecomment-867169250)
* update custom CSS guidance ([#172](#172)) ([5c3725d](5c3725d))

### ✨ New & Improved

* adopt variable ([#200](#200)) ([947e31e](947e31e))

### 🛠 Fixes & Updates

* **deps-dev:** bump @babel/core from 7.12.13 to 7.14.6 ([#169](#169)) ([8666a71](8666a71))
* **deps-dev:** bump @commitlint/cli from 11.0.0 to 12.1.4 ([#182](#182)) ([50325ed](50325ed))
* **deps-dev:** bump @commitlint/config-angular from 11.0.0 to 12.1.4 ([#162](#162)) ([227c5ed](227c5ed))
* **deps-dev:** bump @readme/variable from 11.0.0 to 13.4.12 ([#188](#188)) ([16724d8](16724d8))
* **deps-dev:** bump babel-jest from 26.6.3 to 27.0.5 ([#187](#187)) ([dd26212](dd26212))
* **deps-dev:** bump codemirror from 5.59.2 to 5.62.0 ([#177](#177)) ([35eb916](35eb916))
* **deps-dev:** bump eslint from 7.19.0 to 7.29.0 ([#184](#184)) ([7e032cf](7e032cf))
* **deps:** bump hast-util-sanitize from 2.0.3 to 4.0.0 ([#156](#156)) ([e5fda67](e5fda67))
* **deps-dev:** bump puppeteer from 9.1.1 to 10.0.0 ([#191](#191)) ([3218a8d](3218a8d))
* **deps:** bump rehype-react from 5.0.1 to 6.2.1 ([#175](#175)) ([101218f](101218f))
* **deps:** bump rehype-sanitize from 3.0.1 to 4.0.0 ([#176](#176)) ([bb3956d](bb3956d))
* **deps:** bump remark-disable-tokenizers from 1.0.24 to 1.1.0 ([#179](#179)) ([53ae45f](53ae45f))
* **deps-dev:** bump semantic-release from 17.3.8 to 17.4.4 ([#181](#181)) ([ad92db6](ad92db6))
* **deps:** bump unist-util-select from 3.0.4 to 4.0.0 ([#180](#180)) ([caa51ff](caa51ff))
* **deps-dev:** bump webpack from 4.46.0 to 5.39.0 ([#170](#170)) ([91523e8](91523e8))
* **deps-dev:** bump webpack-merge from 5.7.3 to 5.8.0 ([#174](#174)) ([ea0aefa](ea0aefa))
* **deps:** general maintenance ([#186](#186)) ([c2c59b7](c2c59b7))
* updatee package-log.json ([59e2df2](59e2df2))
* **deps:** upgrading syntax-highlighter to 10.8.0 ([#185](#185)) ([6f3c06c](6f3c06c))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants